tests: migrate cypres tests from rekor-search-ui#92
Merged
carlosthe19916 merged 1 commit intosecuresign:mainfrom Dec 16, 2025
Merged
Conversation
Signed-off-by: Carlos Feria <2582866+carlosthe19916@users.noreply.github.com>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideMigrates Rekor Search endpoint end-to-end tests from Cypress to Playwright and introduces a small UI test hook to support the new tests. Sequence diagram for Playwright test opening RekorSearch settingssequenceDiagram
actor Tester
participant PlaywrightTest
participant Browser
participant RekorSearchPage
participant SettingsPanel
Tester->>PlaywrightTest: Run endpoint.spec test
PlaywrightTest->>Browser: page.goto(/rekor-search)
Browser->>RekorSearchPage: Render RekorSearch component
RekorSearchPage->>RekorSearchPage: Render Button with data-testid=settings-button
PlaywrightTest->>Browser: page.getByTestId(settings-button)
Browser-->>PlaywrightTest: Return settings-button handle
PlaywrightTest->>Browser: settings-button.click()
Browser->>RekorSearchPage: Dispatch click event on settings-button
RekorSearchPage->>RekorSearchPage: setSettingsOpen(true)
RekorSearchPage->>SettingsPanel: Mount and display settings UI
SettingsPanel-->>Tester: Settings visible for assertions
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- Instead of relying on
data-testid="settings-button", consider giving the icon-only settings button an accessible label (e.g.aria-label="Settings") and targeting it via role/name in the Playwright tests to improve both accessibility and selector robustness.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Instead of relying on `data-testid="settings-button"`, consider giving the icon-only settings button an accessible label (e.g. `aria-label="Settings"`) and targeting it via role/name in the Playwright tests to improve both accessibility and selector robustness.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate the tests located at https://github.com/securesign/rekor-search-ui/blob/main/cypress/e2e/endpoint.cy.ts
As Cypress and Playwright are different tools the code might look like a bit different. However the intention of the test should remain the same
Summary by Sourcery
Migrate Rekor Search endpoint end-to-end tests from Cypress to Playwright and add a test hook to the settings button.
New Features:
Enhancements:
Tests: